Skip to content

CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir #10896

wants to merge 1 commit into from

Conversation

@Laur1nMartins
Copy link

@Laur1nMartins Laur1nMartins commented Sep 18, 2025

This change allows the basedir variable to contain spaces.

What?

Adds quotes to the basedir variable.

Why?

Without them the script fails when the path contains spaces.

yosefe
yosefe reviewed Sep 18, 2025
View reviewed changes
@Laur1nMartins Laur1nMartins marked this pull request as draft September 19, 2025 07:35
@Laur1nMartins Laur1nMartins changed the title Update configure-devel to handle spaces in basedir BUILD/SCRIPTS: Update configure-devel to handle spaces in basedir Sep 19, 2025
@Laur1nMartins Laur1nMartins changed the title BUILD/SCRIPTS: Update configure-devel to handle spaces in basedir CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir Sep 19, 2025
@Laur1nMartins Laur1nMartins marked this pull request as ready for review September 19, 2025 07:53
yosefe
yosefe previously approved these changes Sep 20, 2025
View reviewed changes
@tvegas1
Copy link
Contributor

tvegas1 commented Sep 23, 2025

to unblock ci please add diff below and fix commit title with:
./contrib/squash_commit.sh -m "CONTRIB/CONFIGURE: Update configure scripts to handle spaces in basedir" -r origin/master

diff --git a/AUTHORS b/AUTHORS
index c25b3bb6a..116dfe9a2 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -59,6 +59,7 @@ Keisuke Fukuda <[email protected]>
 Ken Raffenetti <[email protected]>
 Khaled Hamidouche <[email protected]>
 Konstantin Belousov <[email protected]>
+Laurin Martins <[email protected]>
 Leonid Genkin <[email protected]>
 Lior Paz <[email protected]>
 Luis E. Pena <[email protected]>

tvegas1
tvegas1 previously approved these changes Sep 23, 2025
View reviewed changes
@Laur1nMartins Laur1nMartins dismissed stale reviews from yosefe and tvegas1 via d928b7c September 23, 2025 15:37
@yosefe
Copy link
Contributor

yosefe commented Sep 25, 2025

Hi @Laur1nMartins , in order to merge the patch to upstream a signed CLA is required - https://github.com/openucx/ucx/wiki/Guidance-for-contributors. Any chance you already signed it previously?

@Laur1nMartins
Copy link
Author

Laur1nMartins commented Oct 7, 2025

Was on vacation. Just sent the CLA thingy to the admin email.

@Laur1nMartins
Copy link
Author

Laur1nMartins commented Nov 7, 2025

Finally got approved. Should be ready now as far as i can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yosefe yosefe yosefe approved these changes

@tvegas1 tvegas1 tvegas1 approved these changes

Assignees

No one assigned

Labels

Approved pending CLA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Laur1nMartins @tvegas1 @yosefe